Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Depth prepass generates linear depth #7119

Merged
merged 3 commits into from
Nov 20, 2024
Merged

Depth prepass generates linear depth #7119

merged 3 commits into from
Nov 20, 2024

Conversation

mvaligursky
Copy link
Contributor

@mvaligursky mvaligursky commented Nov 18, 2024 •
edited
Loading

  • the depth prepass used to render to a depth buffer. If the scene was rendering MSAA, so was the prepass. Then we'd resolve the depth buffer to a single sampled non-linear depth buffer.
  • following passes requiring the depth (ssao, ssao blur, taa) would sample from it and linearise the depth, which was reasonably costly
  • we're now heading towards having mip levels (maybe just 0 and 1) of the depth to accelerate the SSAO
  • and so the depth prepass now always renders single sampled, and in addition to the depth buffer (which is discarded at the end of the pass) it directly writes out linear depth, allowing faster processing in the following passes.

@mvaligursky mvaligursky self-assigned this Nov 18, 2024
@mvaligursky mvaligursky added area: graphics Graphics related issue enhancement labels Nov 18, 2024
@mvaligursky mvaligursky requested a review from a team November 18, 2024 15:38
@mvaligursky mvaligursky merged commit cd7ae45 into main Nov 20, 2024
8 checks passed
@mvaligursky mvaligursky deleted the mv-prepass-lineear-depth branch November 20, 2024 11:45
@mvaligursky mvaligursky mentioned this pull request Nov 22, 2024
Open
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slimbuck slimbuck slimbuck approved these changes

Assignees

@mvaligursky mvaligursky

Labels
area: graphics Graphics related issue enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mvaligursky @slimbuck